Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): add AWS SDK SigV4 support #5586

Merged
merged 1 commit into from
Dec 14, 2023

Conversation

syall
Copy link
Contributor

@syall syall commented Dec 14, 2023

Issue

Issue number, if available, prefixed with "#"

N/A.

Description

What does this implement/fix? Explain your changes.

Add AWS SDK SigV4 support in experimentalIdentityAndAuth.

This is heavily based on https://github.com/aws/aws-sdk-js-v3/blob/main/packages/middleware-signing.

Testing

How was this change tested?

CI passes in staging PR, tested with STS and DynamoDB commands: #5587

Additional context

Add any other context about the PR here.

N/A.

Checklist

  • If you wrote E2E tests, are they resilient to concurrent I/O?
  • If adding new public functions, did you add the @public tag and enable doc generation on the package?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@syall syall force-pushed the ts-ia-add-aws-sdk-sigv4-support branch from 8ea2770 to 7d0bbd1 Compare December 14, 2023 14:30
@syall syall marked this pull request as ready for review December 14, 2023 14:43
@syall syall requested a review from a team as a code owner December 14, 2023 14:43
@syall syall merged commit 9a97df5 into aws:main Dec 14, 2023
3 checks passed
@syall syall deleted the ts-ia-add-aws-sdk-sigv4-support branch December 14, 2023 16:44
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants