-
Notifications
You must be signed in to change notification settings - Fork 592
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add yarn codegen script calling Gradle script #545
chore: add yarn codegen script calling Gradle script #545
Conversation
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
6d892f9
to
008014a
Compare
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
package.json
Outdated
"bootstrap": "yarn", | ||
"clean": "yarn clear-build-cache && yarn clear-build-info && lerna clean", | ||
"clear-build-cache": "rimraf ./packages/*/build/* ./clients/*/*/build/*", | ||
"clear-build-info": "rimraf ./packages/*/*.tsbuildinfo ./clients/*/*/*.tsbuildinfo", | ||
"copy-models": "node ./scripts/copyModels.js", | ||
"update-clients": "node ./packages/package-generator/build/cli.js import-all --matching './models/*/*/service-2.json'", | ||
"build:crypto-dependencies": "lerna run --scope '@aws-sdk/types' --scope '@aws-sdk/util-utf8-browser' --scope '@aws-sdk/util-locate-window' --scope '@aws-sdk/hash-node' --include-filtered-dependencies pretest", | ||
"build:smithy-client": "lerna run --scope '@aws-sdk/client-rds-data' --include-filtered-dependencies pretest", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can build:smithy-client get dropped now?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is still needed if we want to test the build of our only client -- client-rds-data
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok. We may want to cut-over to using the new script so it gets exercised. Codegen for a single model should be pretty quick.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
build:smithy-client
is for compiling the client and its dependencies from TS to JS. It basically has nothing todo with the codegen script
package.json
Outdated
"bootstrap": "yarn", | ||
"clean": "yarn clear-build-cache && yarn clear-build-info && lerna clean", | ||
"clear-build-cache": "rimraf ./packages/*/build/* ./clients/*/*/build/*", | ||
"clear-build-info": "rimraf ./packages/*/*.tsbuildinfo ./clients/*/*/*.tsbuildinfo", | ||
"copy-models": "node ./scripts/copyModels.js", | ||
"update-clients": "node ./packages/package-generator/build/cli.js import-all --matching './models/*/*/service-2.json'", | ||
"build:crypto-dependencies": "lerna run --scope '@aws-sdk/types' --scope '@aws-sdk/util-utf8-browser' --scope '@aws-sdk/util-locate-window' --scope '@aws-sdk/hash-node' --include-filtered-dependencies pretest", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lerna complains about --include-filtered-dependencies being deprecated. This could change this to --include-dependencies if we want to bump lerna.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will do
use use '--include-dependencies' in replace of '--include-filtered-dependencies'
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread. |
Now you can generate smithy-sourced clients from Smithy models by running
This scripts will:
./gradlew :sdk-codegen:clean", ":sdk-codegen:build
clients
)Prerequisites: You need to publish smithy-typescript packages to local maven before running this: https://github.com/awslabs/smithy-typescript
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.