Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(signature-v4-multi-region): add warning when dynamically loading CRT #5243

Merged
merged 1 commit into from
Sep 22, 2023

Conversation

kuhe
Copy link
Contributor

@kuhe kuhe commented Sep 21, 2023

Issue

related to preparation for #5229

Description

Adds warning when dynamically loading CRT on demand.
Users will be instructed to move to explicit loading. The warning will only emit once at most if the user does not import the CRT package.

Testing

Local testing

@kuhe kuhe requested a review from a team as a code owner September 21, 2023 22:23
@kuhe kuhe merged commit 0558bb4 into aws:main Sep 22, 2023
2 checks passed
@kuhe kuhe deleted the chore/crt-warning branch September 22, 2023 15:35
@github-actions
Copy link

github-actions bot commented Oct 7, 2023

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants