Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(scripts): git fetch origin provided commit in codegen #5159

Merged
merged 3 commits into from
Aug 31, 2023

Conversation

trivikr
Copy link
Member

@trivikr trivikr commented Aug 31, 2023

Issue

Internal JS-4680

Description

Our internal CI was doing shallow clone till the last tag for smithy-typescript. When new tag was released in commit smithy-lang/smithy-typescript@e9a378b, our preview/release builds started failing as default commit was not available.

This PR calls git fetch origin for the provided commit in codegen, so that the commit is available.

Testing

Verified that codegen is successful by default (smithy-typescript is shallow cloned)

$ aws-sdk-js-v3> yarn generate-clients -g codegen/sdk-codegen/aws-models/acm.json -n
...
Cloning into '/local/home/trivikr/workspace/smithy-typescript'...
From https://github.com/awslabs/smithy-typescript
 * branch            d942a87081c0ca101f77b2336042773b26b0b9b1 -> FETCH_HEAD
Switched to a new branch 'temp-d942a87081c0ca101f77b2336042773b26b0b9b1'
...
Done in 19.83s.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@trivikr trivikr requested a review from a team as a code owner August 31, 2023 19:08
@trivikr trivikr merged commit 9b6655a into aws:main Aug 31, 2023
2 checks passed
@trivikr trivikr deleted the generate-clients-git-fetch-origin branch August 31, 2023 19:15
@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants