Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(token-providers): declare dependencies from sso-oidc bundle #5064

Merged
merged 1 commit into from
Aug 8, 2023

Conversation

kuhe
Copy link
Contributor

@kuhe kuhe commented Aug 8, 2023

Issue

fixes #5056

Description

declare dependencies from sso oidc to use as bundle externals in token-providers

Testing

npx run turbo and yarn lerna run build did not detect cycles

@kuhe kuhe requested a review from a team as a code owner August 8, 2023 17:24
@kuhe kuhe force-pushed the fix/token-providers branch from 5eeee9a to 21d4cf9 Compare August 8, 2023 17:25
@kuhe kuhe closed this Aug 8, 2023
@kuhe kuhe reopened this Aug 8, 2023
@kuhe kuhe marked this pull request as draft August 8, 2023 17:46
@kuhe kuhe closed this Aug 8, 2023
@kuhe kuhe reopened this Aug 8, 2023
@kuhe kuhe marked this pull request as ready for review August 8, 2023 20:32
@trivikr trivikr merged commit 380482b into aws:main Aug 8, 2023
@kuhe kuhe deleted the fix/token-providers branch August 8, 2023 20:49
@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Undeclared Dependencies in [email protected]
2 participants