Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix bugs when recursively appending middleware #476

Merged
merged 1 commit into from
Dec 2, 2019

Conversation

AllanZhengYP
Copy link
Contributor

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@AllanZhengYP AllanZhengYP added the smithy-codegen Changes regarding supporting smithy model. Will be merged to smithy-codegen branch label Nov 28, 2019
@aws-sdk-js-automation
Copy link

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@codecov-io
Copy link

Codecov Report

Merging #476 into smithy-codegen will decrease coverage by 0.06%.
The diff coverage is 91.66%.

Impacted file tree graph

@@                Coverage Diff                 @@
##           smithy-codegen     #476      +/-   ##
==================================================
- Coverage            94.6%   94.53%   -0.07%     
==================================================
  Files                  68       68              
  Lines                1280     1282       +2     
  Branches              254      255       +1     
==================================================
+ Hits                 1211     1212       +1     
- Misses                 69       70       +1
Impacted Files Coverage Δ
packages/middleware-stack/src/MiddlewareStack.ts 88.61% <91.66%> (-0.39%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5442275...4795b12. Read the comment docs.

@AllanZhengYP AllanZhengYP requested a review from srchase December 2, 2019 20:00
@AllanZhengYP
Copy link
Contributor Author

Failed code cov, but it's just 1 line missing and it's hard to cover.

@AllanZhengYP AllanZhengYP merged commit a29da24 into aws:smithy-codegen Dec 2, 2019
@lock
Copy link

lock bot commented Dec 9, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@lock lock bot locked as resolved and limited conversation to collaborators Dec 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
smithy-codegen Changes regarding supporting smithy model. Will be merged to smithy-codegen branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants