Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update updated types #474

Merged
merged 1 commit into from
Nov 27, 2019
Merged

Conversation

AllanZhengYP
Copy link
Contributor

  • Use HttpRequest interface instread of class when implementation is not necessary
  • Make request serializer async just like response deserializer. This makes the serde symmetric

Issue #, if available:

Description of changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

* Use HttpRequest interface instread of class when implementation is not necessary
* Make request serializer async just like response deserializer. This makes the serde symmetric
@aws-sdk-js-automation
Copy link

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@AllanZhengYP AllanZhengYP requested a review from srchase November 27, 2019 20:50
@codecov-io
Copy link

Codecov Report

Merging #474 into smithy-codegen will decrease coverage by 0.56%.
The diff coverage is 90.32%.

Impacted file tree graph

@@                Coverage Diff                @@
##           smithy-codegen    #474      +/-   ##
=================================================
- Coverage           95.17%   94.6%   -0.57%     
=================================================
  Files                  72      68       -4     
  Lines                1389    1280     -109     
  Branches              272     254      -18     
=================================================
- Hits                 1322    1211     -111     
- Misses                 67      69       +2
Impacted Files Coverage Δ
packages/signature-v4/src/getCanonicalHeaders.ts 100% <ø> (ø) ⬆️
packages/signature-v4/src/getPayloadHash.ts 100% <ø> (ø) ⬆️
packages/signature-v4/src/constants.ts 100% <100%> (ø) ⬆️
packages/signature-v4/src/suite.fixture.ts 100% <100%> (ø) ⬆️
packages/signature-v4/src/cloneRequest.ts 100% <100%> (ø) ⬆️
packages/signature-v4/src/SignatureV4.ts 100% <100%> (ø) ⬆️
...ckages/node-http-handler/src/write-request-body.ts 71.42% <100%> (ø) ⬆️
packages/node-http-handler/src/server.mock.ts 76.66% <100%> (+2.47%) ⬆️
packages/signature-v4/src/getCanonicalQuery.ts 100% <100%> (ø) ⬆️
packages/signature-v4/src/moveHeadersToQuery.ts 84.61% <66.66%> (-15.39%) ⬇️
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c9ca34d...7bb5135. Read the comment docs.

@AllanZhengYP AllanZhengYP merged commit 5442275 into aws:smithy-codegen Nov 27, 2019
@lock
Copy link

lock bot commented Dec 4, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@lock lock bot locked as resolved and limited conversation to collaborators Dec 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants