feat(middleware-logger): log request errors #4252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonbuchan
force-pushed
the
log-errors
branch
from
02e11cb to
01799b4
Compare
kuhe
approved these changes
Mar 7, 2023
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Fixes: #1912
Description
Logs to
logger.errorif the next function rejects or throws.Testing
Other than unit tests, this is essentially the custom middleware I've been using in our auth code for about a week now (including going through our tests).
Additional context
This probably isn't 100% - e.g. it doesn't test for
logger.infobeing present but not a function, and I'm not sure if it's OK to use?..Note that you can't get the
outputfor an error response, since it failed to create it, logically enough!It's probably worthwhile documenting the logging output format, though I don't know where that should go.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.