Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(streams): add readme section about stream mixins #4036

Merged
merged 5 commits into from
Oct 13, 2022

Conversation

kuhe
Copy link
Contributor

@kuhe kuhe commented Oct 12, 2022

  • update readme to make stream mixin helpers known
  • fix the type declaration for WithSdkStreamMixin<OutputType, OutputStreamMemberKey>

@kuhe kuhe requested a review from a team as a code owner October 12, 2022 20:18
@kuhe kuhe changed the title doc(stream): add readme section about stream mixins docs(streams): add readme section about stream mixins Oct 12, 2022
Copy link
Member

@trivikr trivikr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, minor comments

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@trivikr trivikr merged commit 7434604 into aws:main Oct 13, 2022
@kuhe kuhe deleted the doc/stream branch October 13, 2022 15:38
@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants