Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(codegen): add query compatible header error code handling for JSON protocols #3972

Merged
merged 1 commit into from
Oct 3, 2022

Conversation

AndrewFossAWS
Copy link
Contributor

@AndrewFossAWS AndrewFossAWS commented Sep 21, 2022

Description

  • This commit adds query compatible header handling for JSON protocols only
  • When an AWS service sends a x-amzn-query-error header, it contains an error code and type.
  • Example header: x-amzn-query-error:InternalFailure;Receiver
    • InternalFailure is the error code
    • Receiver is the Type
  • Note: The value is always a ; delimited string e.g. InternalFailure;Receiver, MalformedInput;Sender

Testing

  • Generated clients using json protocol
  • Verified code generation is correct

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@trivikr trivikr changed the title feat(codegen): Add query compatible header error code handling for JSON protocols feat(codegen): add query compatible header error code handling for JSON protocols Sep 21, 2022
@AndrewFossAWS AndrewFossAWS force-pushed the awsquerycompat branch 9 times, most recently from 1086d6f to e845201 Compare September 28, 2022 20:18
@AndrewFossAWS AndrewFossAWS merged commit 8fe1b54 into aws:main Oct 3, 2022
@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants