Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(util-body-length-node): move calculateBodyLength to it's own file #3381

Merged
merged 3 commits into from
Mar 8, 2022

Conversation

trivikr
Copy link
Member

@trivikr trivikr commented Feb 28, 2022

Issue

Refactoring before fix for #3377 is posted.

Description

Moves calculateBodyLength to it's own file, and adds missing unit tests

Testing

Unit testing

Additional context

This PR will be rebased after #3380 is merged.


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@trivikr trivikr force-pushed the refactor-util-body-length-node branch from c676502 to a3d1a8c Compare March 1, 2022 18:15
@trivikr trivikr marked this pull request as ready for review March 1, 2022 18:15
@trivikr trivikr requested a review from a team as a code owner March 1, 2022 18:15
@trivikr trivikr requested a review from AllanZhengYP March 1, 2022 18:16
@trivikr trivikr merged commit d3714e1 into aws:main Mar 8, 2022
@trivikr trivikr deleted the refactor-util-body-length-node branch March 8, 2022 17:05
@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants