fix(client-s3): revert MRAP customizations #2759
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The @aws-sdk/[email protected] released with MRAP customization that instroduces `aws-crt` dependency. The dependency takes up too much disk space that blocks Lambda users deploying S3 client with certain deployers. Rollback the change to unblock these users. The MRAP users that's not affected by the dependency size can ping to the older version `@aws-sdk/[email protected]`
adamthom-amzn
approved these changes
Sep 7, 2021
justinboswell
approved these changes
Sep 7, 2021
aws-crt-bot
approved these changes
Sep 7, 2021
|
aws-crt also dramatically complicates using the SDK, as it introduces native code compilation. Glad to see this reverted. |
AllanZhengYP
added a commit
to AllanZhengYP/aws-sdk-js-v3
that referenced
this pull request
Sep 17, 2021
This reverts commit cfb3fff.
AllanZhengYP
added a commit
to AllanZhengYP/aws-sdk-js-v3
that referenced
this pull request
Sep 18, 2021
This reverts commit cfb3fff.
AllanZhengYP
added a commit
that referenced
this pull request
Sep 20, 2021
…s point (#2796) * Revert "fix(client-s3): revert MRAP customizations (#2759)" This reverts commit cfb3fff. * chore: update mrap packages dependencies * feat(middleware-sdk-s3): dynamically import aws-crt package optional dependencies * feat(middleware-user-agent): track if aws-crt is available at runtime * chore: update crt signer loading error message * chore(middleware-sdk-s3): add crt package to dev dependency and track usage This makes sure the type of CRT package is available and the Lerna builds packages in right order--build crt signer package before buiding s3 middleware package. * docs(client-s3): add docs to Bucket members on using MRAP * chore(signature-v4-crt): update crt version to ^1.9.7 * fix(client-s3): address PR feedbacks
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts 3d07ed2, 49da47b
The
@aws-sdk/[email protected]released with MRAP dataplane customization that instroducesaws-crtdependency. The dependency takes up too much disk space that blocksLambda users deploying S3 client with certain deployers.
Rollback the change to unblock these users. The MRAP users that's not affected
by the dependency size can ping to the older version
@aws-sdk/[email protected]Issue
Resolves #2750 #2747
Testing
TBD
Additional context
P52174768
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.