Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: set logger to empty by default in RuntimeConfig #1493

Merged
merged 4 commits into from
Sep 3, 2020

Conversation

trivikr
Copy link
Member

@trivikr trivikr commented Sep 2, 2020

Issue #, if available:
Follow-up to #1472

Description of changes:
Three commits to review:

  • b74462d: only sets up middleware in Logger plugin
  • 24db032: adds optional logger as empty in shared RuntimeConfig
  • b9673c8: remove unused loggerMiddleware configurations

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@trivikr trivikr force-pushed the remove-logger-config branch from 4ec1933 to 8a9eb78 Compare September 2, 2020 01:48
@codecov-commenter
Copy link

codecov-commenter commented Sep 2, 2020

Codecov Report

Merging #1493 into master will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1493      +/-   ##
==========================================
- Coverage   79.80%   79.77%   -0.04%     
==========================================
  Files         298      299       +1     
  Lines       11502    11805     +303     
  Branches     2475     2483       +8     
==========================================
+ Hits         9179     9417     +238     
- Misses       2323     2388      +65     
Impacted Files Coverage Δ
...l_tests/aws-json/commands/EmptyOperationCommand.ts 90.00% <0.00%> (-10.00%) ⬇️
...ts/aws-query/commands/NoInputAndNoOutputCommand.ts 90.00% <0.00%> (-10.00%) ⬇️
.../aws-restxml/commands/NoInputAndNoOutputCommand.ts 90.00% <0.00%> (-10.00%) ⬇️
...aws-restjson/commands/NoInputAndNoOutputCommand.ts 90.00% <0.00%> (-10.00%) ⬇️
protocol_tests/aws-ec2/commands/XmlBlobsCommand.ts 95.00% <0.00%> (-5.00%) ⬇️
protocol_tests/aws-ec2/commands/XmlEnumsCommand.ts 95.00% <0.00%> (-5.00%) ⬇️
protocol_tests/aws-ec2/commands/XmlListsCommand.ts 95.00% <0.00%> (-5.00%) ⬇️
...rotocol_tests/aws-query/commands/XmlMapsCommand.ts 95.00% <0.00%> (-5.00%) ⬇️
...otocol_tests/aws-query/commands/XmlBlobsCommand.ts 95.00% <0.00%> (-5.00%) ⬇️
...otocol_tests/aws-query/commands/XmlEnumsCommand.ts 95.00% <0.00%> (-5.00%) ⬇️
... and 106 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e2f33c1...b9673c8. Read the comment docs.

@trivikr trivikr force-pushed the remove-logger-config branch from 8a9eb78 to b9673c8 Compare September 2, 2020 02:16
@trivikr trivikr changed the title chore: set logger to undefined in RuntimeConfig chore: set logger to empty by default in RuntimeConfig Sep 2, 2020
@trivikr trivikr merged commit 003fd0e into aws:master Sep 3, 2020
@trivikr trivikr deleted the remove-logger-config branch September 3, 2020 18:44
@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants