Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: log metadata/input/output/request/response #1478

Merged
merged 3 commits into from
Aug 31, 2020

Conversation

trivikr
Copy link
Member

@trivikr trivikr commented Aug 28, 2020

Issue #, if available:
Internal JS-2037

Description of changes:
log metadata/input/output/request/response

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Reason: logger will be passed through context
CodeGen passes options to getXPlugin commands, but
loggerMiddleware reads logger from context
@codecov-commenter
Copy link

Codecov Report

Merging #1478 into master will increase coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1478      +/-   ##
==========================================
+ Coverage   79.80%   79.83%   +0.03%     
==========================================
  Files         298      298              
  Lines       11502    11522      +20     
  Branches     2475     2477       +2     
==========================================
+ Hits         9179     9199      +20     
  Misses       2323     2323              
Impacted Files Coverage Δ
packages/property-provider/src/memoize.ts 100.00% <0.00%> (ø)
protocol_tests/aws-ec2/EC2ProtocolClient.ts 93.10% <0.00%> (+0.79%) ⬆️
protocol_tests/aws-json/JsonProtocolClient.ts 93.10% <0.00%> (+0.79%) ⬆️
protocol_tests/aws-query/QueryProtocolClient.ts 93.10% <0.00%> (+0.79%) ⬆️
...rotocol_tests/aws-restxml/RestXmlProtocolClient.ts 93.10% <0.00%> (+0.79%) ⬆️
...tocol_tests/aws-restjson/RestJsonProtocolClient.ts 93.10% <0.00%> (+0.79%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d55a812...b5c8762. Read the comment docs.

@trivikr
Copy link
Member Author

trivikr commented Aug 28, 2020

Build fails because of StackOverflow error discussed in #1460

Confirmed that the rebuild is successful

@trivikr trivikr requested a review from AllanZhengYP August 31, 2020 15:37
Copy link
Contributor

@alexforsyth alexforsyth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, minor feedback.

Copy link
Contributor

@AllanZhengYP AllanZhengYP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Just have a minor comment

@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants