-
Notifications
You must be signed in to change notification settings - Fork 585
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: log metadata/input/output/request/response #1478
Conversation
Reason: logger will be passed through context
CodeGen passes options to getXPlugin commands, but loggerMiddleware reads logger from context
Codecov Report
@@ Coverage Diff @@
## master #1478 +/- ##
==========================================
+ Coverage 79.80% 79.83% +0.03%
==========================================
Files 298 298
Lines 11502 11522 +20
Branches 2475 2477 +2
==========================================
+ Hits 9179 9199 +20
Misses 2323 2323
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, minor feedback.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Just have a minor comment
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread. |
Issue #, if available:
Internal JS-2037
Description of changes:
log metadata/input/output/request/response
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.