Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Codegen doesn't add new dependency in the client if package.json is already present #804

Closed
trivikr opened this issue Jan 28, 2020 · 3 comments
Labels
bug This issue is a bug.

Comments

@trivikr
Copy link
Member

trivikr commented Jan 28, 2020

Describe the bug
Codegen doesn't add new dependency in the client if package.json is already present

To Reproduce (observed behavior)
This issue was noticed when release script failed in #798

Expected behavior

  • generate-clients scripts should read package.json output from CodeGen, and update it to latest lerna dependencies
  • if we go ahead with this solution, we'll need another task to update dependencies while merging as lerna would update version everyday post GA. This can be done using GitHub action on merge action.
@trivikr
Copy link
Member Author

trivikr commented Jan 29, 2020

This issue caused CI failure when codegen was run after uuid dependency was added #815 (comment)

@trivikr
Copy link
Member Author

trivikr commented Feb 11, 2020

Verified that #900 fixed this issue

@trivikr trivikr closed this as completed Feb 11, 2020
@lock
Copy link

lock bot commented Feb 18, 2020

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@lock lock bot locked as resolved and limited conversation to collaborators Feb 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug This issue is a bug.
Projects
None yet
Development

No branches or pull requests

2 participants