feat: sqs md5 validation middleware #719
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srchase
added
the
smithy-codegen
srchase
force-pushed
the
feat-sqs-middleware
branch
from
f1a5bba to
d2f84cd
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
AllanZhengYP
previously requested changes
Jan 14, 2020
srchase
force-pushed
the
feat-sqs-middleware
branch
from
015caf5 to
10accfa
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
srchase
force-pushed
the
smithy-codegen
branch
from
3d60c59 to
9e81bd4
Compare
added 2 commits
January 20, 2020 10:33
feat: apply sqs plugins fix: package name
srchase
force-pushed
the
feat-sqs-middleware
branch
from
10accfa to
f6de585
Compare
Codecov Report
@@ Coverage Diff @@
## smithy-codegen #719 +/- ##
==================================================
- Coverage 92.58% 92.35% -0.23%
==================================================
Files 138 141 +3
Lines 2684 2761 +77
Branches 463 478 +15
==================================================
+ Hits 2485 2550 +65
- Misses 199 211 +12
Continue to review full report at Codecov.
|
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
trivikr
dismissed
AllanZhengYP’s stale review
The comments were addressed, and @AllanFly120 is OOTO
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
trivikr
approved these changes
Jan 21, 2020
This was referenced Jan 21, 2020
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrates and applies message validation middleware for SQS clients
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.