Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing Output structure for DescribeClusterCommand from client-kafka #4653

Closed
3 tasks done
pfarkya opened this issue Apr 24, 2023 · 6 comments
Closed
3 tasks done

Missing Output structure for DescribeClusterCommand from client-kafka #4653

pfarkya opened this issue Apr 24, 2023 · 6 comments
Assignees
Labels
bug This issue is a bug. needs-review This issue/pr needs review from an internal developer. p0 This issue is the highest priority

Comments

@pfarkya
Copy link

pfarkya commented Apr 24, 2023

Checkboxes for prior research

Describe the bug

Before the version 3.315.0 of @aws-sdk/client-kafka does returns the object with deep nested value. Now it doess't contain most of the fields from output structure.

SDK version number

@aws-sdk/[email protected]

Which JavaScript Runtime is this issue in?

Node.js

Details of the browser/Node.js/ReactNative version

16.18.0

Reproduction Steps

Run the following code snippet with version 3.312.0 and version 3.315.0. Add Credential and ARN value before running it.

const { DescribeClusterCommand, KafkaClient } = require('@aws-sdk/client-kafka')
const cli = new KafkaClient({region: 'us-east-1'})
const command = new DescribeClusterCommand({ClusterArn: '<ARN VALUE>'})
try {
  const response = await cli.send(command)
   console.log()
} catch (error) {
   console.error(error)
}

Observed Behavior

{
  '$metadata': {
    httpStatusCode: 200,
    requestId: '<>',
    extendedRequestId: undefined,
    cfId: '<>',
    attempts: 1,
    totalRetryDelay: 0
  },
  ClusterInfo: {
    ClusterArn: '<>',
    ClusterName: '<>',
    CurrentVersion: '<>',
    EnhancedMonitoring: 'DEFAULT',
    NumberOfBrokerNodes: 3,
    State: 'ACTIVE',
    StorageMode: '<>',
    Tags: { },
    ZookeeperConnectString: '<>',
    ZookeeperConnectStringTls: '<>'
  }
}

Expected Behavior

{
  '$metadata': {
    httpStatusCode: 200,
    requestId: '<>',
    extendedRequestId: undefined,
    cfId: '<>',
    attempts: 1,
    totalRetryDelay: 0
  },
  ClusterInfo: {
    ClusterArn: '<>',
    BrokerNodeGroupInfo : { 
      ClientSubnets: ['']
     },
     ClientAuthentication: {
        Unauthenticated: {
          Enabled: true
        }
     }
    ClusterName: '<>',
    CurrentVersion: '<>',
    EnhancedMonitoring: 'DEFAULT',
    NumberOfBrokerNodes: 3,
    State: 'ACTIVE',
    StorageMode: '<>',
    Tags: { },
    ZookeeperConnectString: '<>',
    ZookeeperConnectStringTls: '<>'
  }
}

Possible Solution

Might passing wrong value to take function. In this PR #4625. Deserialisation might be need to change.

Additional Information/Context

No response

@pfarkya pfarkya added bug This issue is a bug. needs-triage This issue or PR still needs to be triaged. labels Apr 24, 2023
pfarkya pushed a commit to pfarkya/aws-sdk-js-v3 that referenced this issue Apr 24, 2023
Wrong input to function `take` cause clusterInfo omit some properties.

Refs: aws#4653
@RanVaknin
Copy link
Contributor

Hi @pfarkya ,

Thanks for bringing this issue up and raising the PR.
This issue is with the Smithy-typescript code generator. I have confirmed the reported behavior and we will work on it with priority.

Thanks!
Ran~

@RanVaknin RanVaknin self-assigned this Apr 26, 2023
@RanVaknin RanVaknin added needs-review This issue/pr needs review from an internal developer. p1 This is a high priority issue and removed needs-triage This issue or PR still needs to be triaged. labels Apr 26, 2023
@kuhe
Copy link
Contributor

kuhe commented Apr 26, 2023

@pfarkya , Could you use a previous version such as https://www.npmjs.com/package/@aws-sdk/client-kafka/v/3.312.0 while a fix is being worked on?

@kuhe kuhe added p0 This issue is the highest priority and removed p1 This is a high priority issue labels Apr 26, 2023
@kuhe kuhe added p1 This is a high priority issue p0 This issue is the highest priority and removed p0 This issue is the highest priority p1 This is a high priority issue labels Apr 26, 2023
@kuhe
Copy link
Contributor

kuhe commented Apr 27, 2023

A patch was released for this issue in https://www.npmjs.com/package/@aws-sdk/client-kafka/v/3.321.1.

@kuhe kuhe added the closing-soon This issue will automatically close in 4 days unless further comments are made. label Apr 27, 2023
@pfarkya
Copy link
Author

pfarkya commented Apr 27, 2023

@kuhe Thanks for quick resolution.

I didn't aware about that this file is been generated by codegen. Thanks for new PR.

Should I need to close it or it does an automated stuff.

@kuhe
Copy link
Contributor

kuhe commented Apr 27, 2023

You can close this issue if you consider it resolved.

@github-actions github-actions bot removed the closing-soon This issue will automatically close in 4 days unless further comments are made. label Apr 28, 2023
@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug This issue is a bug. needs-review This issue/pr needs review from an internal developer. p0 This issue is the highest priority
Projects
None yet
Development

No branches or pull requests

3 participants