-
Notifications
You must be signed in to change notification settings - Fork 585
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add LoggerConfig to all clients #1472
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1472 +/- ##
==========================================
+ Coverage 79.80% 79.82% +0.02%
==========================================
Files 298 298
Lines 11502 11517 +15
Branches 2475 2475
==========================================
+ Hits 9179 9194 +15
Misses 2323 2323
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, can we rebuild?
The rebuild was successful as mentioned in comment #1472 (comment) |
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread. |
Issue #, if available:
Internal JS-2036
In place of #1470
Description of changes:
LoggerConfig allows logger to be passed during client creation.
In future commits, this logger will be populated in handlerExecutionContext, and the middleware will be updated to log request/response and metadata/input/output
This PR:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.