Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add LoggerConfig to all clients #1472

Merged
merged 4 commits into from
Aug 28, 2020

Conversation

trivikr
Copy link
Member

@trivikr trivikr commented Aug 26, 2020

Issue #, if available:
Internal JS-2036
In place of #1470

Description of changes:
LoggerConfig allows logger to be passed during client creation.
In future commits, this logger will be populated in handlerExecutionContext, and the middleware will be updated to log request/response and metadata/input/output

This PR:

  • Commit 450e3fb adds basic configurations in middleware-logger
  • Commit 393d504 adds initial setup for middleware-logger
  • Commit 1fd11eb adds logger dependency in codegen, and e503b52 generates all clients

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov-commenter
Copy link

Codecov Report

Merging #1472 into master will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1472      +/-   ##
==========================================
+ Coverage   79.80%   79.82%   +0.02%     
==========================================
  Files         298      298              
  Lines       11502    11517      +15     
  Branches     2475     2475              
==========================================
+ Hits         9179     9194      +15     
  Misses       2323     2323              
Impacted Files Coverage Δ
protocol_tests/aws-ec2/EC2ProtocolClient.ts 93.10% <0.00%> (+0.79%) ⬆️
protocol_tests/aws-json/JsonProtocolClient.ts 93.10% <0.00%> (+0.79%) ⬆️
protocol_tests/aws-query/QueryProtocolClient.ts 93.10% <0.00%> (+0.79%) ⬆️
...rotocol_tests/aws-restxml/RestXmlProtocolClient.ts 93.10% <0.00%> (+0.79%) ⬆️
...tocol_tests/aws-restjson/RestJsonProtocolClient.ts 93.10% <0.00%> (+0.79%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e72a9dc...e503b52. Read the comment docs.

@trivikr
Copy link
Member Author

trivikr commented Aug 26, 2020

Original build failed because of issue #1460

Retry build was successful

Copy link
Contributor

@alexforsyth alexforsyth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, can we rebuild?

@trivikr
Copy link
Member Author

trivikr commented Aug 28, 2020

can we rebuild?

The rebuild was successful as mentioned in comment #1472 (comment)

@trivikr trivikr merged commit d55a812 into aws:master Aug 28, 2020
@trivikr trivikr deleted the add-logger-clientconfig branch August 28, 2020 17:41
@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants