test(aws-restjson-server): confirm query values of 0 and false are se…

…rialized (#6010)
aws · Apr 18, 2024 · 3260357 · 3260357
1 parent 5331483
commit 3260357
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 8 deletions.
diff --git a/...codegen/src/main/java/software/amazon/smithy/aws/typescript/codegen/AwsProtocolUtils.java b/...codegen/src/main/java/software/amazon/smithy/aws/typescript/codegen/AwsProtocolUtils.java
@@ -316,13 +316,6 @@ private static boolean filterProtocolTests(
             return true;
         }
 
-        // TODO: Remove when this test case is fixed upstream.
-        // https://github.com/smithy-lang/smithy/pull/2167
-        if (settings.generateServerSdk()
-            && testCase.getId().equals("RestJsonZeroAndFalseQueryValues")) {
-            return true;
-        }
-
         // TODO: remove when there's a decision on separator to use
         // https://github.com/awslabs/smithy/issues/1014
         if (testCase.getId().equals("RestJsonInputAndOutputWithQuotedStringHeaders")) {

diff --git a/private/aws-restjson-server/test/functional/restjson1.spec.ts b/private/aws-restjson-server/test/functional/restjson1.spec.ts
@@ -795,7 +795,7 @@ it("RestJsonSupportsNegativeInfinityFloatQueryValues:ServerRequest", async () =>
 /**
  * Query values of 0 and false are serialized
  */
-it.skip("RestJsonZeroAndFalseQueryValues:ServerRequest", async () => {
+it("RestJsonZeroAndFalseQueryValues:ServerRequest", async () => {
   const testFunction = jest.fn();
   testFunction.mockReturnValue(Promise.resolve({}));
   const testService: Partial<RestJsonService<{}>> = {