Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove type assertions for Property and ObjectProperty #921

Merged
merged 14 commits into from
Jul 29, 2024

Conversation

trivikr
Copy link
Member

@trivikr trivikr commented Jul 28, 2024

Issue

Feature introduced in TypeScript 5.4 https://devblogs.microsoft.com/typescript/announcing-typescript-5-4/#preserved-narrowing-in-closures-following-last-assignments

Description

Removes type assertions for Property and ObjectProperty

Testing

CI


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Copy link

changeset-bot bot commented Jul 28, 2024

🦋 Changeset detected

Latest commit: 6723022

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
aws-sdk-js-codemod Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@trivikr trivikr force-pushed the remove-assert-property branch from 8c78d7e to 66c6361 Compare July 28, 2024 22:22
@trivikr trivikr marked this pull request as ready for review July 29, 2024 00:25
@trivikr trivikr requested a review from a team as a code owner July 29, 2024 00:25
@trivikr trivikr merged commit dbc0fae into main Jul 29, 2024
6 checks passed
@trivikr trivikr deleted the remove-assert-property branch July 29, 2024 00:27
Copy link
Contributor

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant