Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace @ts-ignore with @ts-expect-error #911

Merged
merged 1 commit into from
Jul 26, 2024

Conversation

trivikr
Copy link
Member

@trivikr trivikr commented Jul 26, 2024

Issue

Ensures that redundant @ts-expect-error can be removed if types or TypeScript is updated.
The @ts-expect-error would have caught #909 when upgrading to TypeScript 5.5

Description

Replaces @ts-ignore with @ts-expect-error

Testing

CI


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@trivikr trivikr requested a review from a team as a code owner July 26, 2024 16:20
Copy link

changeset-bot bot commented Jul 26, 2024

⚠️ No Changeset found

Latest commit: 824553d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@trivikr trivikr merged commit e441944 into main Jul 26, 2024
6 checks passed
@trivikr trivikr deleted the replace-ts-ignore-expect-error branch July 26, 2024 16:28
Copy link
Contributor

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant