Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate from prettier+eslint to biome #886

Merged
merged 41 commits into from
Jul 12, 2024
Merged

Migrate from prettier+eslint to biome #886

merged 41 commits into from
Jul 12, 2024

Conversation

trivikr
Copy link
Member

@trivikr trivikr commented Jul 10, 2024

Issue

  • Converting to eslint flat config and v9 has several blockers Switch to eslint flat config #759, especially with eslint-plugin-import.
  • Biome is performant, has less dependencies, and recently won award for prettier compatibility, and is actively maintained. We're considering switching to biome in other AWS projects.

Description

Migrates from prettier+eslint to biomejs

  • Some soft enforced rules like naming conventions are disabled. They can be re-enabled, once the biome equivalent reaches stability.
  • Some recommended rules are turned off. They can be enabled, if required, in future commits.

Testing

CI


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Copy link

changeset-bot bot commented Jul 10, 2024

🦋 Changeset detected

Latest commit: abf8f18

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
aws-sdk-js-codemod Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

socket-security bot commented Jul 10, 2024

🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎

To accept the risk, merge this PR and you will not be notified again.

Alert Package NoteSourceCI
Install scripts npm/[email protected]
  • Install script: postinstall
  • Source: node postinstall.js
🚫
Install scripts npm/@biomejs/[email protected]
  • Install script: postinstall
  • Source: node scripts/postinstall.js
🚫

View full report↗︎

Next steps

What is an install script?

Install scripts are run when the package is installed. The majority of malware in npm is hidden in install scripts.

Packages should not be running non-essential scripts during install and there are often solutions to problems people solve with install scripts that can be run at publish time instead.

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/[email protected] or ignore all packages with @SocketSecurity ignore-all

@trivikr trivikr changed the title [DRAFT2] migrate from prettier+eslint to biome Migrate from prettier+eslint to biome Jul 11, 2024
@trivikr trivikr marked this pull request as ready for review July 11, 2024 16:06
@trivikr trivikr requested a review from a team as a code owner July 11, 2024 16:06
@trivikr trivikr merged commit 517fb7f into main Jul 12, 2024
5 of 6 checks passed
@trivikr trivikr deleted the biome2 branch July 12, 2024 02:58
Copy link
Contributor

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants