Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add generic utility addNamedModule #630

Merged
merged 1 commit into from
Oct 20, 2023
Merged

Conversation

trivikr
Copy link
Member

@trivikr trivikr commented Oct 20, 2023

Issue

This utility will be used in files which add modules outside of client modules, like environment credentials in #598

Description

Adds generic utility addNamedModule

Testing

CI


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@changeset-bot
Copy link

changeset-bot bot commented Oct 20, 2023

⚠️ No Changeset found

Latest commit: 45387af

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@trivikr trivikr marked this pull request as ready for review October 20, 2023 14:47
@trivikr trivikr requested a review from a team as a code owner October 20, 2023 14:47
@trivikr trivikr merged commit 577fc33 into main Oct 20, 2023
3 checks passed
@trivikr trivikr deleted the add-named-module-utility branch October 20, 2023 15:07
Copy link
Contributor

github-actions bot commented Nov 4, 2023

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant