Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename constant PACKAGE_NAME to PACKAGE_NAME_V2 #623

Closed
wants to merge 1 commit into from

Conversation

trivikr
Copy link
Member

@trivikr trivikr commented Oct 18, 2023

Issue

Noticed in #622

Description

Renames constant PACKAGE_NAME to PACKAGE_NAME_V2, to avoid confusion with generic packageName being introduced in #622

Testing

CI


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@trivikr trivikr requested a review from a team as a code owner October 18, 2023 16:01
@trivikr
Copy link
Member Author

trivikr commented Oct 18, 2023

Closing, as we can stick with PACKAGE_NAME for v2.
The v3 @aws-sdk can be added as PACKAGE_SCOPE instead.

@trivikr trivikr closed this Oct 18, 2023
@trivikr trivikr deleted the rename-constant-packagename branch October 18, 2023 16:06
Copy link
Contributor

github-actions bot commented Nov 2, 2023

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant