Add comment to investigate removal of .promise() #2040
trivikrAnnotations
5 errors and 2 warnings
|
src/transforms/v2-to-v3/transformer.spec.ts > v2-to-v3 > api-promise > transforms: orphan-promise.js:
src/transforms/v2-to-v3/transformer.spec.ts#L53
AssertionError: expected '// client is AWS SDK JS v2 client her…' to deeply equal '// client is AWS SDK JS v2 client her…'
- Expected
+ Received
// client is AWS SDK JS v2 client here, but jscodeshift can't detect it because of lack of types/import.
- export const listTables = (client) =>
- // The `.promise()` call might be on an JS SDK v2 client API.
- // If yes, please remove .promise(). If not, remove this comment.
- client.listTables().promise();
+ export const listTables = (client) => client.listTables().promise();
❯ src/transforms/v2-to-v3/transformer.spec.ts:53:31
|
|
call-build / build (20.x)
Process completed with exit code 1.
|
|
call-build / build (18.x)
The job was canceled because "_20_x" failed.
|
|
src/transforms/v2-to-v3/transformer.spec.ts > v2-to-v3 > api-promise > transforms: orphan-promise.js:
src/transforms/v2-to-v3/transformer.spec.ts#L53
AssertionError: expected '// client is AWS SDK JS v2 client her…' to deeply equal '// client is AWS SDK JS v2 client her…'
- Expected
+ Received
// client is AWS SDK JS v2 client here, but jscodeshift can't detect it because of lack of types/import.
- export const listTables = (client) =>
- // The `.promise()` call might be on an JS SDK v2 client API.
- // If yes, please remove .promise(). If not, remove this comment.
- client.listTables().promise();
+ export const listTables = (client) => client.listTables().promise();
❯ src/transforms/v2-to-v3/transformer.spec.ts:53:31
|
|
call-build / build (18.x)
The operation was canceled.
|
|
call-build / build (20.x):
src/transforms/v2-to-v3/apis/index.ts#L8
"export * from './addPromiseRemovalComments'" should occur before "export * from './getV3ClientWaiterApiName'"
|
|
call-build / build (18.x):
src/transforms/v2-to-v3/apis/index.ts#L8
"export * from './addPromiseRemovalComments'" should occur before "export * from './getV3ClientWaiterApiName'"
|