Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #547: Field level POJO accessors #1051

Closed

Conversation

mgreenwood1001
Copy link

Immutable entity support (#547) - I could see using a pattern where-in the domain entity is immutable for "store" behavior. Although, it seems unlikely as the predominate case as I'd likely have some form of transfer object to marshal state to/from the DB where-in I have setters/getters.

Just an option for an implementation that solves this concern as I myself might want to do something similar in some of our use-cases.

Thought this was an interesting problem to solve, here's one possible implementation. Might consider re-using reflectutils rather than directly using java.lang.*... Also might not want to invoke field.set when setter not available...

Tests are needed by this implementation, willing to add them if this is worthy of eventually merging.

@mgreenwood1001 mgreenwood1001 changed the title Issue #547: Field level access Issue #547: Field level POJO accessors Mar 6, 2017
@kiiadi kiiadi self-assigned this Mar 29, 2017
@millems
Copy link
Contributor

millems commented Nov 10, 2017

Sorry for the delay on this.

We've got immutable model support as the first suggestion for V2 of the mapper: aws/aws-sdk-java-v2#35

We're mostly code frozen on major features being added to 1.11.x's mapper. We'll make sure to think about this problem as we redesign V2. Sorry we weren't able to integrate your contribution. We appreciate it.

@millems millems closed this Nov 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants