Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ReturnConsumedCapacity to BatchGetItemEnhancedRequest #4421

Merged
merged 2 commits into from
Sep 12, 2023

Conversation

psnilesh
Copy link
Contributor

@psnilesh psnilesh commented Sep 12, 2023

Motivation and Context

Add ReturnConsumedCapacity to BatchGetItemEnhancedRequest so callers can determine exactly how much RCUs BatchGetItem request consumed.

Related to feature request #4372

Modifications

  1. Add returnConsumedCapacity to BatchGetItemEnhancedRequest
  2. Changes to BatchGetItemOperation to honor returnConsumedCapacity
  3. Unit and functional tests to verify the new param

Testing

Added new unit and functional tests, and ran them succcesfully

./mvnw clean install -pl :dynamodb-enhanced --am

Screenshots (if appropriate)

N/A

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • I have read the CONTRIBUTING document
  • Local run of mvn install succeeds
  • My code follows the code style of this project
  • My change requires a change to the Javadoc documentation
  • I have updated the Javadoc documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed
  • I have added a changelog entry. Adding a new entry must be accomplished by running the scripts/new-change script and following the instructions. Commit the new file created by the script in .changes/next-release with your changes.
  • My change is to implement 1.11 parity feature and I have updated LaunchChangelog

License

  • I confirm that this pull request can be released under the Apache 2 license

@psnilesh psnilesh requested a review from a team as a code owner September 12, 2023 14:21
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

100.0% 100.0% Coverage
1.8% 1.8% Duplication

@davidh44
Copy link
Contributor

Thanks for the contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants