-
Notifications
You must be signed in to change notification settings - Fork 856
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide a clearer exception message when building a ReadBatch or WriteBatch without setting the mappedTableResource (table) #4267
Conversation
58b633f
to
2fb4633
Compare
@swar8080 I understand the problem, but I don't think we should deprecate the current builder for this. |
2fb4633
to
eba498d
Compare
…teBatch without setting the mappedTableResource (table)
eba498d
to
6f08eb3
Compare
@debora-ito okay I just updated the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks for the contribution!
…ch-builder-safety
…ch-builder-safety
…ch-builder-safety
Kudos, SonarCloud Quality Gate passed! |
@all-contributors please add @swar8080 for code |
I've put up a pull request to add @swar8080! 🎉 |
Currently, a NullPointerException is thrown if you forget to call the
WriteBatch
builder withmappedTableResource(MappedTableResource<T>)
.ReadBatch
has the same problemMotivation and Context
Modifications
Add a clearer error message in the
NullPointerException
letting the person know they forgot to set amappedTableResource
Testing
Updated unit tests
Types of changes
Checklist
mvn install
succeedsscripts/new-change
script and following the instructions. Commit the new file created by the script in.changes/next-release
with your changes.License