Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add import mapping for endpoints-spi #3506

Merged
merged 2 commits into from
Oct 21, 2022
Merged

Add import mapping for endpoints-spi #3506

merged 2 commits into from
Oct 21, 2022

Conversation

dagnir
Copy link
Contributor

@dagnir dagnir commented Oct 20, 2022

Motivation and Context

Modifications

Add mapping.

Testing

Created a test branch to trigger import and verified that the internal package we're mapping to is created.

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • I have read the CONTRIBUTING document
  • Local run of mvn install succeeds
  • My code follows the code style of this project
  • My change requires a change to the Javadoc documentation
  • I have updated the Javadoc documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed
  • I have added a changelog entry. Adding a new entry must be accomplished by running the scripts/new-change script and following the instructions. Commit the new file created by the script in .changes/next-release with your changes.
  • My change is to implement 1.11 parity feature and I have updated LaunchChangelog

License

  • I confirm that this pull request can be released under the Apache 2 license

@dagnir dagnir marked this pull request as ready for review October 20, 2022 22:01
@dagnir dagnir requested a review from a team as a code owner October 20, 2022 22:02
@dagnir dagnir enabled auto-merge (squash) October 20, 2022 22:04
@dagnir dagnir disabled auto-merge October 20, 2022 23:54
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@dagnir dagnir merged commit 1d2aa77 into master Oct 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cenedhryn cenedhryn cenedhryn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dagnir @cenedhryn