Add "ConcurrencyAcquireDuration" metric for netty-nio-client #2903
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
December 8, 2021 21:02
The time taken to acquire a new channel from a channel pool can be both non-trivial and highly variable, depending upon whether a new connection needs to be established, and depending upon the overhead of new connection establishment (including TLS handshakes). Due to the high variability, having an explicit metric can be helpful to give a better picture of latency sources in impacted requests.
Bennett-Lynch
commented
Dec 9, 2021
http-client-spi/src/main/java/software/amazon/awssdk/http/HttpMetric.java
Outdated
Show resolved
Hide resolved
http-client-spi/src/main/java/software/amazon/awssdk/http/HttpMetric.java
Show resolved
Hide resolved
dagnir
reviewed
Dec 9, 2021
...client/src/main/java/software/amazon/awssdk/http/nio/netty/internal/NettyRequestMetrics.java
Show resolved
Hide resolved
http-client-spi/src/main/java/software/amazon/awssdk/http/HttpMetric.java
Outdated
Show resolved
Hide resolved
cenedhryn
reviewed
Dec 10, 2021
Bennett-Lynch
changed the title
dagnir
approved these changes
Dec 10, 2021
zoewangg
approved these changes
Dec 10, 2021
cenedhryn
approved these changes
Dec 10, 2021
|
Kudos, SonarCloud Quality Gate passed! |
Bennett-Lynch
pushed a commit
to Bennett-Lynch/aws-sdk-java-v2
that referenced
this pull request
Dec 11, 2021
The time taken to acquire a new channel from a channel pool can be both non-trivial and highly variable, depending upon whether a new connection needs to be established, and depending upon the overhead of new connection establishment (including TLS handshakes). The same metric was recently added for netty-nio-client: aws#2903
1 task
Bennett-Lynch
added a commit
that referenced
this pull request
Dec 14, 2021
* Add "ConcurrencyAcquireDuration" metric for apache-client The time taken to acquire a new channel from a channel pool can be both non-trivial and highly variable, depending upon whether a new connection needs to be established, and depending upon the overhead of new connection establishment (including TLS handshakes). The same metric was recently added for netty-nio-client: #2903
aws-sdk-java-automation
added a commit
that referenced
this pull request
Feb 19, 2024
…7642dcdbc Pull request: release <- staging/cfb5cdd1-2611-4344-b88e-c977642dcdbc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The time taken to acquire a new channel from a channel pool can be both
non-trivial and highly variable, depending upon whether a new connection
needs to be established, and depending upon the overhead of new
connection establishment (including TLS handshakes). Due to the high
variability, having an explicit metric can be helpful to give a better
picture of latency sources in impacted requests.
License