Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Script generate_cross_link_data should be run before mvn install #2656

Merged
merged 1 commit into from
Aug 11, 2021
Merged

Script generate_cross_link_data should be run before mvn install #2656

merged 1 commit into from
Aug 11, 2021

Conversation

joviegas
Copy link
Contributor

Motivation and Context

  • Redirection of Java doc stopped working after Update javadocs release cross-linking script #2591
  • The 2591 fix started using pathlib.Path(r'./services') to get all the service2.json files. However, when we run mvn install we generate target build files which started affecting the scripts output.
  • Thus thus this script must be run before we do any mvn install.

Description

  • Updated the release-javadoc.yml to run generate_cross_link_data before we start the mvn install.

  • A short description of the change has been added to the CHANGELOG ==> Not required since this does not impact the release or any feature used by users.

Testing

  • Tested by running this in internally and making sure the redirects are working.

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • I have read the CONTRIBUTING document
  • Local run of mvn install succeeds
  • My code follows the code style of this project
  • My change requires a change to the Javadoc documentation
  • I have updated the Javadoc documentation accordingly
  • I have read the README document
  • I have added tests to cover my changes
  • All new and existing tests passed
  • A short description of the change has been added to the CHANGELOG
  • My change is to implement 1.11 parity feature and I have updated LaunchChangelog

License

  • I confirm that this pull request can be released under the Apache 2 license

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@joviegas joviegas merged commit 9e80b51 into aws:master Aug 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants