Add support for plus (+) character in profile names #2089
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Original PR #2050)
SDK doesn't support plus ('+') character in profile names. Similar to #1847 and #389.
Description
Adds '+' character to allowed list of characters so that
ProfileFileReader
doesn't ignore profile names with '+' character in it.Motivation and Context
When using "namespaced" profile names (e.g.:
profileBaseName+customId
) this is a hard limitation. Ideally, SDKs should support similar core features (such as handling profile names the similar way) independently of implementation language.Testing
Unit tests
Screenshots (if appropriate)
n/a
Types of changes
Checklist
mvn install
succeedsLicense