Throws IOException for an h2 connection acquiring race condition #1614
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zoewangg
force-pushed
the
zoewang-closedChannelException
branch
from
b4b739d to
e9d93a4
Compare
millems
approved these changes
Jan 24, 2020
| if (!connection.isActive()) { | ||
| return false; | ||
| } | ||
|
|
There was a problem hiding this comment.
Do we know that this actually helps, or are we just guessing?
There was a problem hiding this comment.
As discussed offline, the check does not cover for all cases and we need to figure out a better way to reduce the race condition. Removed it for now.
… gets picked up at the same time it gets closed
zoewangg
force-pushed
the
zoewang-closedChannelException
branch
from
e9d93a4 to
ca6fb14
Compare
zoewangg
changed the title
millems
approved these changes
Jan 24, 2020
|
SonarCloud Quality Gate failed.
|
Codecov Report
@@ Coverage Diff @@
## master #1614 +/- ##
============================================
+ Coverage 75.69% 75.69% +<.01%
Complexity 682 682
============================================
Files 905 905
Lines 28389 28389
Branches 2257 2257
============================================
+ Hits 21488 21490 +2
+ Misses 5880 5877 -3
- Partials 1021 1022 +1
Continue to review full report at Codecov.
|
aws-sdk-java-automation
added a commit
that referenced
this pull request
Aug 17, 2021
…3b717e14f Pull request: release <- staging/31290513-fea1-4560-8201-54a3b717e14f
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…s picked up at the same time it gets closed
Description
Reduce the chances of the race condition where an HTTP2 connection gets reused at the same time it gets inactiveThrow
IOExceptioninstead ofIllegalStatementExceptionso the failed requests can be retried.Testing
Added unit tests
Screenshots (if appropriate)
Types of changes
Checklist
mvn installsucceedsLicense