Add apache-async-client #1543
Closed
Add apache-async-client #1543
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michael-o
suggested changes
Dec 10, 2019
...client/src/main/java/software/amazon/awssdk/http/apache/async/ApacheAsyncRequestFactory.java
Outdated
Show resolved
Hide resolved
...client/src/main/java/software/amazon/awssdk/http/apache/async/ApacheAsyncRequestFactory.java
Outdated
Show resolved
Hide resolved
rschmitt
force-pushed
the
apache-async-client
branch
from
a9c8d8d to
039b460
Compare
michael-o
suggested changes
Dec 10, 2019
...-async-client/src/main/java/software/amazon/awssdk/http/apache/async/ProxyConfiguration.java
Outdated
Show resolved
Hide resolved
rschmitt
force-pushed
the
apache-async-client
branch
3 times, most recently
from
2a9ffcf to
41f383d
Compare
rschmitt
force-pushed
the
apache-async-client
branch
6 times, most recently
from
5fe2ceb to
c3abf7e
Compare
rschmitt
force-pushed
the
apache-async-client
branch
5 times, most recently
from
156b23c to
abc3d20
Compare
rschmitt
force-pushed
the
apache-async-client
branch
from
abc3d20 to
fa77504
Compare
|
I've updated this PR to depend on the latest beta. It no longer requires snapshot builds and is in pretty good shape to merge to a feature branch or something. |
|
SonarCloud Quality Gate failed.
|
This commit adds a new `SdkAsyncHttpClient` implementation, `ApacheAsyncHttpClient`, as well as a service provider for that implementation. These live in a new module, apache-async-client, which is part of the http-clients module. This client is intended to be roughly equivalent in power to the netty-nio-client, supporting features like HTTP/2, full-duplex HTTP requests, and reactive streams. The client supports the following options: | Option | Default value | Defined by... | Implemented via... | | ------------------------------ | ------------- | ------------------- | ------------------------------------- | | `socketTimeout` | 30 sec | http-client-spi | `IOReactorConfig` | | `connectionTimeout` | 2 sec | http-client-spi | `RequestConfig` | | `connectionAcquisitionTimeout` | 20 sec | http-client-spi | `RequestConfig` | | `maxConnections` | 50 | http-client-spi | `PoolingAsyncClientConnectionManager` | | `proxyConfiguration` | empty object | apache-async-client | `HttpAsyncClient` | | `localAddress` | `null` | apache-async-client | `HttpAsyncClient` | | `expectContinueEnabled` | `true` | apache-async-client | `RequestConfig` | | `connectionTimeToLive` | unlimited | http-client-spi | `PoolingAsyncClientConnectionManager` | | `connectionMaxIdleTime` | 60 sec | http-client-spi | `HttpAsyncClient` | | `protocol` | `null` | http-client-spi | `HttpVersionPolicy` | | `maxHttp2Streams` | `null` | apache-async-client | `H2Config` | | `httpRoutePlanner` | `null` | apache-async-client | `HttpAsyncClient` | | `credentialsProvider` | `null` | apache-async-client | `HttpAsyncClient` | | `tlsKeyManagersProvider` | JVM defaults | http-client-spi | `SSLContext` | The following standard options are not supported: * `SdkHttpConfigurationOption.WRITE_TIMEOUT`: `socketTimeout` maps to `READ_TIMEOUT`, which controls both read and write behavior on every client except netty-nio-client * `SdkHttpConfigurationOption.MAX_PENDING_CONNECTION_ACQUIRES`: Apache supports an acquisition timeout, not a limit on the number of pending connection acquires
rschmitt
force-pushed
the
apache-async-client
branch
from
7d239e4 to
d6a705b
Compare
aws-sdk-java-automation
added a commit
that referenced
this pull request
Jul 16, 2021
…1c59d118c Pull request: release <- staging/c2eace12-0c83-44d0-9b5d-c351c59d118c
|
Hey Ryan, I'm going to go ahead and close this as the branch has gone stale. I think we as a team should also discuss how want to handle new HTTP client implementations going forward. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds a new
SdkAsyncHttpClientimplementation,ApacheAsyncHttpClient, as well as a service provider for thatimplementation. These live in a new module, apache-async-client, which
is part of the http-clients module.
This client is intended to be roughly equivalent in power to the
netty-nio-client, supporting features like HTTP/2, full-duplex HTTP
requests, and reactive streams.
The client supports the following options:
socketTimeoutIOReactorConfigconnectionTimeoutRequestConfigconnectionAcquisitionTimeoutRequestConfigmaxConnectionsPoolingAsyncClientConnectionManagerproxyConfigurationHttpAsyncClientlocalAddressnullHttpAsyncClientexpectContinueEnabledtrueRequestConfigconnectionTimeToLivePoolingAsyncClientConnectionManagerconnectionMaxIdleTimeHttpAsyncClientprotocolnullHttpVersionPolicymaxHttp2StreamsnullH2ConfighttpRoutePlannernullHttpAsyncClientcredentialsProvidernullHttpAsyncClienttlsKeyManagersProviderSSLContextThe following standard options are not supported:
SdkHttpConfigurationOption.WRITE_TIMEOUT:socketTimeoutmaps toREAD_TIMEOUT, which controls both read and write behavior on everyclient except netty-nio-client
SdkHttpConfigurationOption.MAX_PENDING_CONNECTION_ACQUIRES: Apachesupports an acquisition timeout, not a limit on the number of pending
connection acquires