Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

S3: Interacting with an access point in a different region to the one… #1537

Merged
merged 1 commit into from
Dec 4, 2019

Conversation

bmaizels
Copy link
Contributor

@bmaizels bmaizels commented Dec 4, 2019

… the S3 client is configured for will no longer result in the request being signed for the wrong region and rejected by S3.

Testing

Added unit test and integration test for scenario.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • I have read the CONTRIBUTING document
  • Local run of mvn install succeeds
  • My code follows the code style of this project
  • My change requires a change to the Javadoc documentation
  • I have updated the Javadoc documentation accordingly
  • I have read the README document
  • I have added tests to cover my changes
  • All new and existing tests passed
  • A short description of the change has been added to the CHANGELOG
  • My change is to implement 1.11 parity feature and I have updated LaunchChangelog

License

  • I confirm that this pull request can be released under the Apache 2 license

… the S3 client is configured for will no longer result in the request being signed for the wrong region and rejected by S3.
import static software.amazon.awssdk.awscore.AwsExecutionAttribute.AWS_REGION;
import static software.amazon.awssdk.core.interceptor.SdkExecutionAttribute.SERVICE_CONFIG;
import static software.amazon.awssdk.utils.http.SdkHttpUtils.urlEncode;

import java.net.URI;
import java.util.Optional;
import org.junit.Test;

import software.amazon.awssdk.auth.signer.AwsSignerExecutionAttribute;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clean them imports

@bmaizels bmaizels merged commit 1d2d644 into master Dec 4, 2019
@bmaizels bmaizels deleted the bmaizels/accesspoint-signing-fix branch December 4, 2019 01:05
aws-sdk-java-automation added a commit that referenced this pull request Jul 14, 2021
…788554657

Pull request: release <- staging/711e8f67-93b9-4491-bbf4-c4a788554657
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants