Don't leak Native CrtResources if error occurs during close #1408
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
millems
reviewed
Sep 10, 2019
...ents/aws-crt-client/src/main/java/software/amazon/awssdk/http/crt/AwsCrtAsyncHttpClient.java
Outdated
Show resolved
Hide resolved
JonathanHenson
approved these changes
Sep 10, 2019
millems
approved these changes
Sep 10, 2019
aws-sdk-java-automation
added a commit
that referenced
this pull request
May 20, 2021
…57e44f4d1 Pull request: release <- staging/79194a54-2030-4ab2-a3b0-1da57e44f4d1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Don't leak Native CrtResources if error occurs during close.
Motivation and Context
Testing
Screenshots (if appropriate)
Types of changes
Checklist
mvn installsucceedsLicense