Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add design for automatic event streaming reconnects. #1236

Merged
merged 3 commits into from
May 2, 2019

Conversation

millems
Copy link
Contributor

@millems millems commented May 1, 2019

No description provided.

@codecov-io
Copy link

codecov-io commented May 1, 2019

Codecov Report

Merging #1236 into master will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1236      +/-   ##
============================================
+ Coverage     59.19%   59.21%   +0.01%     
- Complexity     4660     4663       +3     
============================================
  Files           750      750              
  Lines         23288    23288              
  Branches       1744     1744              
============================================
+ Hits          13786    13790       +4     
+ Misses         8806     8803       -3     
+ Partials        696      695       -1
Impacted Files Coverage Δ Complexity Δ
...on/awssdk/services/kinesis/KinesisRetryPolicy.java 85.71% <0%> (ø) 3% <0%> (+1%) ⬆️
...ware/amazon/awssdk/utils/cache/CachedSupplier.java 87.8% <0%> (+2.43%) 14% <0%> (+1%) ⬆️
...nio/netty/internal/OldConnectionReaperHandler.java 90.9% <0%> (+9.09%) 13% <0%> (+1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6e07bfa...6a7cbb2. Read the comment docs.

responseHandler);

// New method that transparently reconnects on network errors (name to be bikeshed)
client.startStreamTranscriptionWithReconnects(audioMetadata,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not that it matters too much as name is TBD but the name you use here is different than in the Option 1 code.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch.

@millems millems merged commit 0c3a8ec into master May 2, 2019
@millems millems deleted the millem/event-streaming-reconnects branch March 17, 2020 23:38
aws-sdk-java-automation pushed a commit that referenced this pull request Mar 18, 2021
…b1a04ced2

Pull request: release <- staging/00ae843f-0304-4967-808c-138b1a04ced2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants