-
Notifications
You must be signed in to change notification settings - Fork 858
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add design for automatic event streaming reconnects. #1236
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1236 +/- ##
============================================
+ Coverage 59.19% 59.21% +0.01%
- Complexity 4660 4663 +3
============================================
Files 750 750
Lines 23288 23288
Branches 1744 1744
============================================
+ Hits 13786 13790 +4
+ Misses 8806 8803 -3
+ Partials 696 695 -1
Continue to review full report at Codecov.
|
responseHandler); | ||
|
||
// New method that transparently reconnects on network errors (name to be bikeshed) | ||
client.startStreamTranscriptionWithReconnects(audioMetadata, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not that it matters too much as name is TBD but the name you use here is different than in the Option 1 code.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch.
…b1a04ced2 Pull request: release <- staging/00ae843f-0304-4967-808c-138b1a04ced2
No description provided.