-
Notifications
You must be signed in to change notification settings - Fork 864
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Netty HTTP Proxy Support #858
Comments
Any status updates on this? |
@dagnir - any update on this? |
Hi @favetelinguis @vinayys we still have this planned, but have not begun work on this yet. |
this is very much needed for anyone working in enterprise,.,.,,,, |
This is a major issue for us adopting it. |
We want to use Spring Boot Webflux to build reactive services. Currently will have to wrap SDK calls in their own separate thread pools rather than just using Netty all the way through. Spring Boot lets you inject a Reactor Netty HttpClient, but I assume you all are using Netty directly instead of Reactor Netty so that wouldn't be available. |
+1 |
Can we please add the proxy config support for DynamoDbAsyncClient ????? I am in urgent need. |
Hi @BhargavChoksi, this feature was built into the Netty HTTP client instead of at the service clients level. To use the Netty client's proxying feature with the DynamoDB client, you will need to configure the Netty client directly on the client: SdkAsyncHttpClient.Builder nettyBuilder = NettyNioAsyncHttpClient.builder()
.proxyConfiguration(ProxyConfiguration.builder()
...
.build());
DynamoDbAsyncClient ddb = DynamoDbAsyncClient.builder()
.httpClientBuilder(nettyBuilder)
.build(); |
Thanks a lot @dagnir, for your quick response. Here, I am able to set proxy-host and proxy-port. It seems there is no way to set proxy-username ans proxy-password or I am horribly missing something? final ProxyConfiguration proxyConfiguration = |
Hey @BhargavChoksi That is not currently supported at the moment. This is being tracked here: #1432 |
Marking this is done. Other proxy related features will be tracked separately (e.g. #1432) |
Thanks for implementing this, it's working well for me. One note though, the example configuration here shows using the |
…2184b821 Pull request: release <- staging/8f43e0d7-b401-409e-81ea-21882184b821
The Apache HTTP implementation supports proxy configuration, but Netty does not. This feature should be added to Netty.
The text was updated successfully, but these errors were encountered: