Test cases to check on Failure

aws · Sep 8, 2023 · 9247f21 · 9247f21
1 parent 65ddbca
commit 9247f21
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 19 deletions.
diff --git a/services-custom/s3-transfer-manager/pom.xml b/services-custom/s3-transfer-manager/pom.xml
@@ -212,6 +212,11 @@
             <version>${commons-codec.verion}</version>
             <scope>test</scope>
         </dependency>
+        <dependency>
+            <artifactId>wiremock-jre8</artifactId>
+            <groupId>com.github.tomakehurst</groupId>
+            <scope>test</scope>
+        </dependency>
     </dependencies>
 
     <build>

diff --git a/...rc/it/java/software/amazon/awssdk/transfer/s3/S3TransferManagerUploadIntegrationTest.java b/...rc/it/java/software/amazon/awssdk/transfer/s3/S3TransferManagerUploadIntegrationTest.java
@@ -26,7 +26,6 @@
 import java.util.Map;
 import java.util.UUID;
 import java.util.concurrent.CancellationException;
-import java.util.concurrent.CompletionException;
 import org.junit.jupiter.api.AfterAll;
 import org.junit.jupiter.api.BeforeAll;
 import org.junit.jupiter.api.Test;
@@ -35,7 +34,6 @@
 import software.amazon.awssdk.core.sync.ResponseTransformer;
 import software.amazon.awssdk.services.s3.model.ChecksumAlgorithm;
 import software.amazon.awssdk.services.s3.model.GetObjectResponse;
-import software.amazon.awssdk.services.s3.model.NoSuchBucketException;
 import software.amazon.awssdk.testutils.RandomTempFile;
 import software.amazon.awssdk.transfer.s3.model.CompletedFileUpload;
 import software.amazon.awssdk.transfer.s3.model.CompletedUpload;
@@ -148,20 +146,4 @@ void upload_file_Interupted_CancelsTheListener() throws IOException, Interrupted
         assertThat(transferListener.getRatioTransferredList().get(transferListener.getRatioTransferredList().size() - 1))
             .isNotEqualTo(100.0);
     }
-
-    @Test
-    void upload_file_errorPropagatedToListener() throws IOException, InterruptedException {
-        Map<String, String> metadata = new HashMap<>();
-        CaptureTransferListener transferListener = new CaptureTransferListener();
-        metadata.put("x-amz-meta-foobar", "FOO BAR");
-        FileUpload fileUpload =
-            tm.uploadFile(u -> u.putObjectRequest(p -> p.bucket(TEST_BUCKET+TEST_BUCKET).key(TEST_KEY).metadata(metadata).checksumAlgorithm(ChecksumAlgorithm.CRC32))
-                                .source(testFile.toPath())
-                                .addTransferListener(LoggingTransferListener.create())
-                                .addTransferListener(transferListener)
-                                .build());
-        assertThatExceptionOfType(CompletionException.class).isThrownBy(
-            () -> fileUpload.completionFuture().join());
-        assertThat(transferListener.getExceptionCaught()).isInstanceOf(NoSuchBucketException.class);
-    }
 }
diff --git a/...ain/java/software/amazon/awssdk/services/s3/internal/crt/S3CrtResponseHandlerAdapter.java b/...ain/java/software/amazon/awssdk/services/s3/internal/crt/S3CrtResponseHandlerAdapter.java
@@ -152,7 +152,6 @@ private void onErrorResponseComplete(byte[] errorPayload) {
     }
 
     private void failResponseHandlerAndFuture(Throwable exception) {
-        this.progressListener.subscriberOnError(exception);
         resultFuture.completeExceptionally(exception);
         runAndLogError(log.logger(), "Exception thrown in SdkAsyncHttpResponseHandler#onError, ignoring",
                        () -> responseHandler.onError(exception));