Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prevent unused time import in event streams #4919

Merged
merged 1 commit into from
Jul 20, 2023
Merged

Conversation

lucix-aws
Copy link
Contributor

Event stream codegen blindly imports "time", but doesn't actually use it unless one of the following is true:

  • there's a stream with input
  • a payload or header used in event streaming has a timestamp field

This patch adds a compile-time reference to prevent vet from failing on the unused import (as we've done with "awserr" whose usage is also conditional in event streams).

@lucix-aws lucix-aws merged commit e7c3b25 into main Jul 20, 2023
31 checks passed
@lucix-aws lucix-aws deleted the fix-eventstream-imports branch July 20, 2023 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants