aws/session: Fix client init not exposing endpoint resolve error #3059
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes the SDK API clients not surfacing endpoint resolution errors, when the EndpointResolver is unable to resolve an endpoint for the client and region.
jasdel
added
the
needs-review
skotambkar
reviewed
Dec 31, 2019
| // was created. | ||
| return | ||
| } | ||
| r.Error = err |
There was a problem hiding this comment.
Would be helpful to check if we need to wrap this error
There was a problem hiding this comment.
The error that will be returned will be a UnknownEndpointError error with
e.g.
UnknownEndpointError: could not resolve endpoint
partition: "aws", service: "s3", region: "",
skotambkar
approved these changes
Dec 31, 2019
jasdel
removed
the
needs-review
aws-sdk-go-automation
pushed a commit
that referenced
this pull request
Jan 6, 2020
=== ### Service Client Updates * `service/comprehend`: Updates service API and documentation * `service/ec2`: Updates service API and documentation * This release supports service providers configuring a private DNS name for services other than AWS services and services available in the AWS marketplace. This feature allows consumers to access the service using an existing DNS name without making changes to their applications. * `service/mediapackage`: Updates service API and documentation * You can now restrict direct access to AWS Elemental MediaPackage by securing requests for live content using CDN authorization. With CDN authorization, content requests require a specific HTTP header and authorization code. ### SDK Bugs * `aws/session`: Fix client init not exposing endpoint resolve error ([#3059](#3059)) * Fixes the SDK API clients not surfacing endpoint resolution errors, when the EndpointResolver is unable to resolve an endpoint for the client and region.
Merged
aws-sdk-go-automation
added a commit
that referenced
this pull request
Jan 6, 2020
Release v1.27.1 (2020-01-06) === ### Service Client Updates * `service/comprehend`: Updates service API and documentation * `service/ec2`: Updates service API and documentation * This release supports service providers configuring a private DNS name for services other than AWS services and services available in the AWS marketplace. This feature allows consumers to access the service using an existing DNS name without making changes to their applications. * `service/mediapackage`: Updates service API and documentation * You can now restrict direct access to AWS Elemental MediaPackage by securing requests for live content using CDN authorization. With CDN authorization, content requests require a specific HTTP header and authorization code. ### SDK Bugs * `aws/session`: Fix client init not exposing endpoint resolve error ([#3059](#3059)) * Fixes the SDK API clients not surfacing endpoint resolution errors, when the EndpointResolver is unable to resolve an endpoint for the client and region.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the SDK API clients not surfacing endpoint resolution errors, when the EndpointResolver is unable to resolve an endpoint for the client and region.