Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Event Stream SigV4 Chunk Signinging #2996

Merged
merged 3 commits into from
Dec 11, 2019
Merged

Event Stream SigV4 Chunk Signinging #2996

merged 3 commits into from
Dec 11, 2019

Conversation

skmcgrail
Copy link
Member

Implements the SigV4 signing strategy for Event Streams.

@skmcgrail skmcgrail requested a review from jasdel December 7, 2019 01:30
jasdel
jasdel suggested changes Dec 9, 2019
View reviewed changes
Copy link
Contributor

@jasdel jasdel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple suggestions for organizing the signer.

private/protocol/eventstream/eventstreamapi/signer.go Outdated Show resolved Hide resolved
private/protocol/eventstream/eventstreamapi/signer.go Outdated Show resolved Hide resolved
private/protocol/eventstream/eventstreamapi/signer.go Outdated Show resolved Hide resolved
private/protocol/eventstream/eventstreamapi/signer_test.go Show resolved Hide resolved
@skmcgrail skmcgrail force-pushed the eventstream/chunkSigner branch from 9ee9c36 to d52357e Compare December 9, 2019 23:22
@skmcgrail
Copy link
Member Author

Addressed feedback

@skmcgrail skmcgrail requested a review from jasdel December 9, 2019 23:22
@skmcgrail skmcgrail added the needs-review This issue or pull request needs review from a core team member. label Dec 9, 2019
@skmcgrail skmcgrail force-pushed the eventstream/chunkSigner branch from d52357e to b459fc3 Compare December 10, 2019 21:57
@skmcgrail skmcgrail changed the base branch from master to eventstreamIO December 10, 2019 22:02
jasdel
jasdel suggested changes Dec 10, 2019
View reviewed changes
private/protocol/eventstream/eventstreamapi/signer.go Outdated Show resolved Hide resolved
private/protocol/eventstream/eventstreamapi/signer.go Outdated Show resolved Hide resolved
aws/signer/v4/eventstream.go Outdated Show resolved Hide resolved
@skmcgrail skmcgrail force-pushed the eventstream/chunkSigner branch from b459fc3 to a731946 Compare December 11, 2019 17:53
@skmcgrail skmcgrail force-pushed the eventstream/chunkSigner branch from a731946 to 7537010 Compare December 11, 2019 19:42
@skmcgrail skmcgrail requested a review from jasdel December 11, 2019 19:42
jasdel
jasdel approved these changes Dec 11, 2019
View reviewed changes
Copy link
Contributor

@jasdel jasdel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good minor comment on test Error vs Fatal

aws/signer/v4/stream_test.go Show resolved Hide resolved
@skmcgrail skmcgrail merged commit 658bee8 into aws:eventstreamIO Dec 11, 2019
jasdel pushed a commit that referenced this pull request Dec 20, 2019
@skmcgrail @jasdel
Event Stream SigV4 Chunk Signinging (#2996)
f8a22e3
skmcgrail added a commit to skmcgrail/aws-sdk-go that referenced this pull request Dec 23, 2019
@skmcgrail
Event Stream SigV4 Chunk Signinging (aws#2996)
84f860d
@skmcgrail skmcgrail deleted the eventstream/chunkSigner branch January 9, 2020 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasdel jasdel jasdel approved these changes

Assignees
No one assigned
Labels
needs-review This issue or pull request needs review from a core team member.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@skmcgrail @jasdel