aws/client: Adds configurations to the default retryer #2830
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasdel
approved these changes
Sep 12, 2019
jasdel
suggested changes
Sep 12, 2019
| @@ -21,40 +22,103 @@ import ( | |||
| // // This implementation always has 100 max retries | |||
| // func (d retryer) MaxRetries() int { return 100 } | |||
| type DefaultRetryer struct { | |||
There was a problem hiding this comment.
Can update the doc string for this type to be more concise. The new delay members should have doc strings added to them that describe their default behavior as automatically being set of their value is 0.
jasdel
approved these changes
Sep 12, 2019
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exposes members of the default retryer. Adds NoOpRetryer to support no retry behavior. Updates the underlying logic used by the default retryer to calculate jittered delay for retry.
Fixes #2829