Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SQS DeleteMessage returning Unmarshal error when service is unavailable #331

Closed
dstokes opened this issue Jul 31, 2015 · 2 comments
Closed

SQS DeleteMessage returning Unmarshal error when service is unavailable #331

dstokes opened this issue Jul 31, 2015 · 2 comments
Labels
bug This issue is a bug.

Comments

@dstokes
Copy link

dstokes commented Jul 31, 2015

I'm seeing the following error output when receiving a Service Unavailable error response from the Amazon API:

Unmarshal: failed to decode query XML error response
caused by: expected element type <ErrorResponse> but have <ServiceUnavailableException>

I suspect this is being caused by the missing ServiceUnavailableException error type the deleteMessage endpoint schema but I'm not 100% sure. I'm happy to open a pull request if someone more familiar with the project can confirm.
@dstokes dstokes changed the title SQS DeleteMessage returning Unmarshal error when service is unavailabl SQS DeleteMessage returning Unmarshal error when service is unavailable Jul 31, 2015
@jasdel
Copy link
Contributor

jasdel commented Jul 31, 2015

Thanks for reporting the issue @dstokes. I think for this type of error we'll need to handle it genericly since it may be possible for it occur on other services also. I expect once it is fixed, the error returned will have a Code of ServiceUnavailableException

@jasdel jasdel added the bug This issue is a bug. label Jul 31, 2015
@dstokes
Copy link
Author

dstokes commented Jul 31, 2015

@jasdel good point. i noticed it was already declared in some api schemas but handling it generically would resolve it oce and for all, i imagine

@jasdel jasdel mentioned this issue Dec 16, 2015
Closed
jasdel added a commit that referenced this issue Mar 16, 2016
@jasdel
private/protocol/query: Add parsing of ServiceUnavailableException
4def568 
Adds support to fallback and attempt to parse the
ServiceUnavailableException out of the response body. This is helpful
when the requestion failed and the service returned unavailable error.
Previously the error unmarshaller would fail with a serialization error.

Fix #331
jasdel added a commit that referenced this issue Mar 16, 2016
@jasdel
private/protocol/query: Add parsing of ServiceUnavailableException
fdad9d9 
Adds support to fallback and attempt to parse the
ServiceUnavailableException out of the response body. This is helpful
when the request failed and the service returned unavailable error.
Previously the error unmarshaller would fail with a serialization error.

Fix #331
@jasdel jasdel mentioned this issue Mar 16, 2016
Merged
jasdel added a commit that referenced this issue Mar 18, 2016
@jasdel
Tag release v1.1.12
4da0bec 
References:
  #331, #438, #559, #590, #591, #592, #593, #595, #596, #597
xibz pushed a commit to xibz/aws-sdk-go that referenced this issue Apr 18, 2016
@jasdel @xibz
private/protocol/query: Add parsing of ServiceUnavailableException
cfb9e57 
Adds support to fallback and attempt to parse the
ServiceUnavailableException out of the response body. This is helpful
when the request failed and the service returned unavailable error.
Previously the error unmarshaller would fail with a serialization error.

Fix aws#331
xibz pushed a commit to xibz/aws-sdk-go that referenced this issue Apr 18, 2016
@jasdel @xibz
Tag release v1.1.12
3e4095f 
References:
  aws#331, aws#438, aws#559, aws#590, aws#591, aws#592, aws#593, aws#595, aws#596, aws#597
xibz pushed a commit to xibz/aws-sdk-go that referenced this issue Apr 18, 2016
@jasdel @xibz
private/protocol/query: Add parsing of ServiceUnavailableException
0bb45b4 
Adds support to fallback and attempt to parse the
ServiceUnavailableException out of the response body. This is helpful
when the request failed and the service returned unavailable error.
Previously the error unmarshaller would fail with a serialization error.

Fix aws#331
xibz pushed a commit to xibz/aws-sdk-go that referenced this issue Apr 18, 2016
@jasdel @xibz
Tag release v1.1.12
e008d15 
References:
  aws#331, aws#438, aws#559, aws#590, aws#591, aws#592, aws#593, aws#595, aws#596, aws#597
skotambkar added a commit to skotambkar/aws-sdk-go that referenced this issue May 20, 2021
@skotambkar @jasdel
service/rds: Fix presign URL for same region (aws#331)
801e5ee 
Fixes RDS no-autopresign URL for same region issue for aws-sdk-go-v2.

Solves the issue by making sure that the presigned URLs are not created, when the source and destination regions are the same. Added and updated the tests accordingly.

Fix aws#271
skotambkar pushed a commit to skotambkar/aws-sdk-go that referenced this issue May 20, 2021
@jasdel
Release v0.10.0 (2019-07-24) (aws#344)
5208fda 
Services
===
* Synced the V2 SDK with latest AWS service API definitions.
* Fixes [aws#341](aws/aws-sdk-go-v2#341)
* Fixes [aws#342](aws/aws-sdk-go-v2#342)

SDK Breaking Changes
===
* `aws`: Add default HTTP client instead of http.DefaultClient/Transport ([aws#315](aws/aws-sdk-go-v2#315))
  * Adds a new BuildableHTTPClient type to the SDK's aws package. The type uses the builder pattern with immutable changes. Modifications to the buildable client create copies of the client.  Adds a HTTPClient interface to the aws package that the SDK will use as an abstraction over the specific HTTP client implementation. The SDK will default to the BuildableHTTPClient, but a *http.Client can be also provided for custom configuration.  When the SDK's aws.Config.HTTPClient value is a BuildableHTTPClient the SDK will be able to use API client specific request timeout options.
  * Fixes [aws#279](aws/aws-sdk-go-v2#279)
  * Fixes [aws#269](aws/aws-sdk-go-v2#269)

SDK Enhancements
===
* `service/s3/s3manager`: Update S3 Upload Multipart location ([aws#324](aws/aws-sdk-go-v2#324))
  * Updates the Location returned value of S3 Upload's Multipart UploadOutput type to be consistent with single part upload URL. This update also brings the multipart upload Location inline with the S3 object URLs created by the SDK.
  * Fixes [aws#323](aws/aws-sdk-go-v2#323)
  * V2 Port [aws#2453](aws#2453)

SDK Bugs
===
* `private/model`: Handles empty map vs unset map behavior in send request ([aws#337](aws/aws-sdk-go-v2#337))
  * Updated shape marshal model to handle the empty map vs nil map behavior. Adding a test case to assert behavior when a user sends an empty map vs nil map.
  * Fix [aws#332](aws/aws-sdk-go-v2#332)
* `service/rds`: Fix presign URL for same region ([aws#331](aws/aws-sdk-go-v2#331))
  * Fixes RDS no-autopresign URL for same region issue for aws-sdk-go-v2. Solves the issue by making sure that the presigned URLs are not created, when the source and destination regions are the same. Added and updated the tests accordingly.
  * Fix [aws#271](aws/aws-sdk-go-v2#271)
* `private/protocola/json/jsonutil`: Fix Unmarshal map[string]bool ([aws#320](aws/aws-sdk-go-v2#320))
  * Fixes the JSON unmarshaling of maps of bools. The unmarshal case was missing the condition for bool value, in addition the bool pointer.
  * Fix [aws#319](aws/aws-sdk-go-v2#319)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug This issue is a bug.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dstokes @jasdel