Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dynamodbattribute.ConvertX to wiki #281

Closed
jasdel opened this issue Jun 12, 2015 · 4 comments
Closed

Add dynamodbattribute.ConvertX to wiki #281

jasdel opened this issue Jun 12, 2015 · 4 comments

Comments

@jasdel
Copy link
Contributor

jasdel commented Jun 12, 2015

New converts were added to dyanmodb service package to make AttributeValue usage more user friendly. Information about these converts should be added to our wikis. Should probably include package doc line, and a few examples in code comments for godocs.

godocs for dynamodbattribute.ConvertX

Related to #125, #231

@jyehbrightcove
Copy link

I noticed that the library is located at:
github.com/aws/aws-sdk-go/service/dynamodb/dynamodbattribute

It looks like the package declaration is dynamodb, which is the same as the parent folder. Was this intentional? If I try to import both this and the parent, I get a complaint that dynamodb is being redefined.

I figured I might be missing something so I didn't want to raise an issue at first.

@lsegal
Copy link
Contributor

lsegal commented Jun 17, 2015

@jyehbrightcove I just merged a pull request #285 that resolves this, thanks for reporting!

@jyehbrightcove
Copy link

My apologies for not looking at the outstanding PRs.

jasdel added a commit that referenced this issue Aug 13, 2015
Adds additional documentation to the conversion utilities.

Fix: #281
@jasdel
Copy link
Contributor Author

jasdel commented Aug 13, 2015

Documented the functionality via the package doc along with examples.

@jasdel jasdel closed this as completed Aug 13, 2015
jasdel added a commit that referenced this issue Aug 20, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants