Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor shared config Loading #990

Merged
merged 5 commits into from
Dec 22, 2020
Merged

Conversation

skotambkar
Copy link
Contributor

@skotambkar skotambkar commented Dec 19, 2020

PR for Shared Config Loading

Changes:

  • Separates shared config and shared credentials files.
  • Updates shared config handling to be consistent with AWS SDKs and CLI
  • Updates test

TODO:

[ x ] More TESTING
[ x ] Error handling.
[ x ] Logs things that are dropped.
[ x ] Documentation update
[ x ] Config SourceFile should be a list of all filenames that were used to get Config

@skotambkar skotambkar marked this pull request as draft December 19, 2020 00:28
@skotambkar skotambkar marked this pull request as ready for review December 21, 2020 19:06
@skotambkar skotambkar changed the title Draft PR for Shared Config Loading refactor shared config Loading Dec 21, 2020
config/env_config.go Outdated Show resolved Hide resolved
config/load_options.go Outdated Show resolved Hide resolved
config/resolve_assume_role_test.go Show resolved Hide resolved
config/resolve_processcreds_test.go Show resolved Hide resolved
config/shared_config.go Outdated Show resolved Hide resolved
config/shared_config.go Outdated Show resolved Hide resolved
config/shared_config_test.go Outdated Show resolved Hide resolved
config/shared_config_test.go Outdated Show resolved Hide resolved
config/testdata/load_config Show resolved Hide resolved
internal/ini/ini.go Outdated Show resolved Hide resolved
config/shared_config.go Outdated Show resolved Hide resolved
config/shared_config.go Outdated Show resolved Hide resolved
@skotambkar skotambkar requested a review from jasdel December 22, 2020 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants