Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Developer Guide: Configuring the SDK #899

Merged
merged 6 commits into from
Nov 17, 2020

Conversation

skmcgrail
Copy link
Member

@skmcgrail skmcgrail commented Nov 13, 2020

Updates the "Configure the SDK" V1 content to V2 SDK concepts. Topics have been broken up into separate pages in order to make some of the content more bite-sized and easier to discover.

Please only review the content under content/en/docs/configuring-sdk/ which has been updated for V2 and is ready for review.

This changes also includes:

  • Improvements to the apiref short-code so that it can be used with the standard markdown links. Additionally an apiref can be made towards smithy-go by using the smithy= keyword argument.
  • Added dates to pages that were missing them.

Related to #902

@skmcgrail skmcgrail requested a review from jasdel November 13, 2020 19:32
content/en/docs/configuring-sdk/custom-http.md Outdated Show resolved Hide resolved
content/en/docs/configuring-sdk/custom-http.md Outdated Show resolved Hide resolved
content/en/docs/configuring-sdk/endpoints.md Outdated Show resolved Hide resolved
content/en/docs/sessions.md Show resolved Hide resolved
@skmcgrail skmcgrail requested review from Doug-AWS and a team and removed request for a team November 13, 2020 19:53
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm going to approve this, but I do think the bit about setting AWS_PROFILE needs fixing. Otherwise I don't see anything so egregious that it should hold up a merge.

content/en/docs/configuring-sdk/_index.md Outdated Show resolved Hide resolved
content/en/docs/configuring-sdk/_index.md Outdated Show resolved Hide resolved
content/en/docs/configuring-sdk/_index.md Outdated Show resolved Hide resolved
content/en/docs/configuring-sdk/_index.md Outdated Show resolved Hide resolved
content/en/docs/configuring-sdk/_index.md Outdated Show resolved Hide resolved
content/en/docs/configuring-sdk/custom-http.md Outdated Show resolved Hide resolved
content/en/docs/configuring-sdk/custom-http.md Outdated Show resolved Hide resolved
content/en/docs/configuring-sdk/custom-http.md Outdated Show resolved Hide resolved
content/en/docs/configuring-sdk/custom-http.md Outdated Show resolved Hide resolved
content/en/docs/making-requests.md Show resolved Hide resolved
@skmcgrail skmcgrail merged commit 1077c23 into aws:documentation Nov 17, 2020
@skmcgrail skmcgrail deleted the configuringTheSDK branch November 17, 2020 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants