-
Notifications
You must be signed in to change notification settings - Fork 652
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Developer Guide: Configuring the SDK #899
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skmcgrail
commented
Nov 13, 2020
skmcgrail
force-pushed
the
configuringTheSDK
branch
from
November 13, 2020 19:45
0d52ba5
to
b7ebc33
Compare
jasdel
reviewed
Nov 13, 2020
skmcgrail
requested review from
Doug-AWS and
a team
and removed request for
a team
November 13, 2020 19:53
jasdel
reviewed
Nov 13, 2020
jasdel
reviewed
Nov 13, 2020
jasdel
approved these changes
Nov 15, 2020
skmcgrail
force-pushed
the
configuringTheSDK
branch
from
November 16, 2020 04:31
b7ebc33
to
be83d0f
Compare
smckenzie23
approved these changes
Nov 16, 2020
ghost
reviewed
Nov 16, 2020
ghost
reviewed
Nov 16, 2020
ghost
approved these changes
Nov 16, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm going to approve this, but I do think the bit about setting AWS_PROFILE needs fixing. Otherwise I don't see anything so egregious that it should hold up a merge.
Doug-AWS
suggested changes
Nov 16, 2020
Doug-AWS
approved these changes
Nov 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the "Configure the SDK" V1 content to V2 SDK concepts. Topics have been broken up into separate pages in order to make some of the content more bite-sized and easier to discover.
Please only review the content under
content/en/docs/configuring-sdk/
which has been updated for V2 and is ready for review.This changes also includes:
apiref
short-code so that it can be used with the standard markdown links. Additionally an apiref can be made towardssmithy-go
by using thesmithy=
keyword argument.Related to #902