codegen: Update SDK modeled endpoints #791
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skmcgrail
approved these changes
Oct 2, 2020
jasdel
force-pushed
the
fixup/EndpointDef
branch
from
3662879 to
d94ed95
Compare
Adds utility that will sync the endpoint model and endpoint-prefix map from the v1 SDK's models.
jasdel
force-pushed
the
fixup/EndpointDef
branch
from
d94ed95 to
d1b906e
Compare
skotambkar
approved these changes
Oct 2, 2020
| CODEGEN_RESOURCES_PATH=$(shell pwd)/codegen/smithy-aws-go-codegen/src/main/resources/software/amazon/smithy/aws/go/codegen | ||
| ENDPOINTS_JSON=${CODEGEN_RESOURCES_PATH}/endpoints.json | ||
| ENDPOINT_PREFIX_JSON=${CODEGEN_RESOURCES_PATH}/endpoint-prefix.json | ||
|
|
||
| LICENSE_FILE=$(shell pwd)/LICENSE.txt | ||
|
|
||
| all: generate unit |
There was a problem hiding this comment.
Should all call sync-endpoint-models?
There was a problem hiding this comment.
I wasn't sure, how we wanted to do that since this really is a prep for releasing a update. I erred on the side of caution to not make it get the v1 SDK when unneeded. If the SDK had a similar location it could sync the Smithy API models from I'd vote it be included with that set of tasks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates's the SDK's modeled endpoints with the latest version. Regenerates the SDK's API client modules to also use the latest enpdoint version.