Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sdk: Add support for types/enums pkg as sub-packages of each service pkg #441

Closed
wants to merge 9 commits into from
Closed

sdk: Add support for types/enums pkg as sub-packages of each service pkg #441

wants to merge 9 commits into from

Conversation

skotambkar
Copy link
Contributor

@skotambkar skotambkar commented Nov 27, 2019 •
edited by jasdel
Loading

When merging this PR, we should remove api_types, api_enums from all service pkgs.

  • Modifies existing sdk service pkg layout. types and enums sub-packages has been added to service/* pkg.
  • Input, output types along with other api types of a service are now generated in a types sub-package. Every operation has it's own types file which consist of input, output types for each operation.
  • api-enums would now be generated in a enums sub-package.
  • Few additional customizations, code cleanup are introduced for review in this PR.

Related to #445

@skotambkar skotambkar marked this pull request as ready for review November 27, 2019 23:17
This was referenced Nov 29, 2019
Closed
Closed
Closed
Closed
jasdel
jasdel suggested changes Dec 3, 2019
View reviewed changes
private/model/api/api.go Outdated Show resolved Hide resolved
private/model/api/api.go Show resolved Hide resolved
private/model/api/api.go Outdated Show resolved Hide resolved
private/model/api/api.go Outdated Show resolved Hide resolved
private/model/api/customization_passes.go Outdated Show resolved Hide resolved
private/model/api/passes.go Outdated Show resolved Hide resolved
private/model/api/passes.go Outdated Show resolved Hide resolved
private/model/api/shape.go Outdated Show resolved Hide resolved
private/model/api/smoke.go Outdated Show resolved Hide resolved
private/protocol/restxml/build_bench_test.go Outdated Show resolved Hide resolved
@skotambkar skotambkar requested a review from jasdel December 4, 2019 00:55
@skotambkar skotambkar requested a review from skmcgrail December 4, 2019 18:29
This was referenced Dec 6, 2019
Closed
Closed
jasdel
jasdel suggested changes Dec 9, 2019
View reviewed changes
Copy link
Contributor

@jasdel jasdel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Couple suggestions mainly focused on code generation.

aws/example_test.go Outdated Show resolved Hide resolved
example/aws/endpoints/customEndpoint/customEndpoint.go Outdated Show resolved Hide resolved
models/protocol_tests/generate.go Outdated Show resolved Hide resolved
private/model/api/api.go Outdated Show resolved Hide resolved
private/model/api/api.go Outdated Show resolved Hide resolved
private/model/api/shape.go Outdated Show resolved Hide resolved
private/model/api/shape_value_builder.go Outdated Show resolved Hide resolved
private/model/api/smoke.go Outdated Show resolved Hide resolved
private/model/api/waiters.go Outdated Show resolved Hide resolved
service/dynamodb/dynamodbattribute/decode_test.go Outdated Show resolved Hide resolved
@skotambkar skotambkar requested a review from jasdel December 11, 2019 02:46
jasdel
jasdel suggested changes Dec 11, 2019
View reviewed changes
Copy link
Contributor

@jasdel jasdel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good. Added suggesting for validateShapeNames passes.

private/model/api/passes.go Outdated Show resolved Hide resolved
private/model/api/passes.go Show resolved Hide resolved
private/model/api/passes.go Outdated Show resolved Hide resolved
@skotambkar skotambkar requested a review from jasdel December 11, 2019 20:58
@jasdel jasdel added the pr/work-in-progress This PR is a draft and needs further work. label Dec 31, 2019
@skotambkar skotambkar closed this Jan 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skmcgrail skmcgrail Awaiting requested review from skmcgrail

@jasdel jasdel Awaiting requested review from jasdel

Assignees

@skotambkar skotambkar

Labels
pr/work-in-progress This PR is a draft and needs further work.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@skotambkar @jasdel