Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve download.go documentation #1171

Merged
merged 2 commits into from
Mar 18, 2021
Merged

Improve download.go documentation #1171

merged 2 commits into from
Mar 18, 2021

Conversation

vvelikodny
Copy link
Contributor

@vvelikodny vvelikodny commented Mar 13, 2021 •
edited
Loading

Improve Downloader.Download(..) documentation according issue #482 and PR #483

comment about current issue #483 (comment)

@vvelikodny
Update download.go
70e2980 
Improve Downloader.Download(..) documentation according aws#482 and aws#483
@vvelikodny vvelikodny changed the title Update download.go Improve download.go documentation Mar 13, 2021
jasdel
jasdel approved these changes Mar 18, 2021
View reviewed changes
Copy link
Contributor

@jasdel jasdel left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this example to the download manager, the change looks good. we'll get this included in the SDK's next release.

@jasdel jasdel merged commit b9a0b1a into aws:main Mar 18, 2021
@vvelikodny vvelikodny mentioned this pull request Apr 6, 2021
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasdel jasdel jasdel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vvelikodny @jasdel